Clear modifier state when focus is lost #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Awesome, thank you for the fix! |
|
Btw, the motivation for public fields was to allow people to re-use parts of If we ever reach 1.0, the fields will become private. Or it might as well happen sooner, for example, after we merge #299 and provide some API for people to handle tricky input scenarios such as worldspace UI, etc. Anyway, public fields of resources is something I'm open to reconsider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the same thing bevy does for the
ButtonInput<KeyCode>resource here: https://github.com/bevyengine/bevy/blob/d8d49fdd1393ab543a0ed66da9a255fda7d66572/crates/bevy_input/src/keyboard.rs#L151-L155Fixes #232
I'm not sure why all the fields in
InputEventsare public, since it makes this a breaking change and isn't required for things to compile.